You bring up good points. The NRA isn’t perfect, but it does a decent job at the one thing it is supposed to do - promote gun rights. There are a lot of smaller groups out there, and some of them are fine for more local things or to show a solidarity to a subset of gun owner (such as the Pink Pistols and the Jews for the 2nd Amendment), but orgs like Gun Owners of America don’t actually do much in the way of gun rights and are more of a scam, IMHO. Or allowing you to put two stickers on your truck.
It is important to note, most of the money from the NRA comes from PEOPLE. It truly is grass roots. The anti-gun group do get private donors, but not nearly in the same numbers and a lot of it seems to be propped up by small numbers of large donations, vs large numbers of small donations.
Because the issue is soooo split along liberal and conservative, it is seen as an arm of the GOP, but it really isn’t. They are consistent in their support of pro-gun politicians. So if you are a democrat who vote against say 3 gun law bills, you will get an A or B rating, and come election time they will mail a card to the member letting them know this. For example, they keep supporting the local sheriff even though he is a Democrat.
And as you pointed out, they have many more facets than just lobbying. For one they are the ONLY entity with a kids and gun safety program worth a damn and with any sort of recognition. I wish it was bigger. I would HOPE the anti-gun groups have similar programs - but I have never heard of or encountered it out there.
They have the largest certification network for trainers and training. When you see a class for you CCW or just to learn to shoot better, and the trainer is “certified” most likely it is from the NRA. I am sure there are other groups with training systems, but the NRA is by far the largest. (Again, this is why I don’t like GOA and others, as they do nothing in either training or safety, that I am aware of.)
And then there is the legal arm, the one that actually challenges laws in courts. Honestly, this one probably gets the most criticism from people even more hard-lined than the NRA. They have initially shied away from some of the bigger gun law challenges, such as the famous cases in Chicago and DC. I was told this was because they are afraid of losing, which would hurt the smaller, less important cases more. Best to not challenge it, vs lose and then in every case they bring up the opposition can site that case against them.
And finally, they have been making some really good media lately. Notably, Colion Noir’s show, which isn’t prefect, but he defiantly is attempting to break stereotypes and shows more about the fun of shooting, vs focusing on defense or tactical only.
Though the parts about the NRA I don’t like is mainly PR related. They need more of a liberal outreach program. Their alarmist propaganda for donation gets old quick. They need to get rid of some of their more toxic people like Nugent, though the people on the BoD are actually voted in by the members, so the redneck vote needs representation, I guess.